Fix DOM-based XSS on home page pool table#51
Merged
Conversation
Channel/zone/valve names are copied verbatim from bus payloads and were injected into the home page via innerHTML, allowing script execution in the viewer's browser if a name contained HTML. Build the table cells with textContent instead so bus-derived strings are never parsed as markup. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AkBZ1XBd8VUSDgN7JYAzhq
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AkBZ1XBd8VUSDgN7JYAzhq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Channel/zone/valve names are copied verbatim from bus payloads and were
injected into the home page via innerHTML, allowing script execution in
the viewer's browser if a name contained HTML. Build the table cells with
textContent instead so bus-derived strings are never parsed as markup.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01AkBZ1XBd8VUSDgN7JYAzhq